Add Pointer#read_array_of and Pointer#write_array_of #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tduehr, anything wrong with this ? |
|
@tduehr, can you either close this with a good reason or merge ? |
tduehr
requested changes
Apr 13, 2017
furunkel
force-pushed
the
read_write_array_of
branch
from
c7afdbd
to
d644c08
Compare
|
@tduehr, ok, added some more specs and reimplemented straight in C; hope you deem this merge-worthy now. |
|
Needs a bit of tweaking, but I'll get it from here. |
…of, Pointer#put_array_of
furunkel
force-pushed
the
read_write_array_of
branch
from
d644c08
to
0156293
Compare
|
@tduehr, refactored the code, for consistency it now raises |
|
@tduehr any chance of getting this in ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
Pointer#read_array_of_typeandPointer#write_array_of_typeand introducesPointer#read_array_ofandPointer#writer_array_of.The former two weren't useful at all as one had to pass, along with the type, a corresponding writer/reader.