Add FFI::AbstractMemory#read_array_of_string #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was defined but not exposed to Ruby nor tested. Fixes ffi#1070
|
@eregon This method is missing in Truffleruby. We could implement it here as a ruby method, but since JRuby already implements it natively, I tend to do it equally in all 3 implementations. Would you mind to add |
|
Yeah, I will add it. |
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Apr 23, 2024
* Tests from ffi/ffi#1096
|
Will be fixed in oracle/truffleruby#3550 |
|
@larskanis I restarted the truffleruby CI jobs, it's all green now, so I'll merge this. |
eregon
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was defined but not exposed to Ruby nor tested.
Fixes #1070