Update FFI::Pointer#== to not throw an exception #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this? |
… FFI::Pointer or descendants an exception is thrown - "INTERNAL ERROR!!! TypeError: wrong argument type Module (expected FFI::Pointer). In my case, this then causes the RubyMine debugger (debase) to blow up, making debugging harder. This PR updates FFI::Pointer#== to return false if a pointer is compared to a non-pointer object, which is the expected behavior.
|
Sure, added a few tests for Pointer#== |
|
Thank you, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call FFI::Pointer#== with an instance of an object that is not FFI::Pointer or descendants an exception is thrown:
In my case, this then causes the RubyMine debugger (debase) to blow up, making debugging harder.
This PR updates FFI::Pointer#== to return false if a pointer is compared to a non-pointer object, which is the expected behavior.