Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying to store new DataConverter type in frozen TypeDefs hash #1057

Merged
merged 1 commit into from Sep 29, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Sep 29, 2023

Fixes #1056.

@mvz mvz marked this pull request as ready for review September 29, 2023 07:30
@larskanis
Copy link
Member

larskanis commented Sep 29, 2023

Very nice! Thanks a lot, especially for the new test case!

It was quite a challenge to make ffi compatible to Ractor and properly usable in a Ractor context. I just added a Wiki page about it: https://github.com/ffi/ffi/wiki/Ractors

@larskanis larskanis merged commit 13afd23 into ffi:master Sep 29, 2023
39 checks passed
@mvz
Copy link
Contributor Author

mvz commented Sep 29, 2023

Thanks, @larskanis!

@mvz mvz deleted the avoid-frozen-typemap branch September 29, 2023 10:30
@larskanis
Copy link
Member

ffi-1.16.3 is released with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't modify frozen Hash error when evaluating layout containing DataConverter
2 participants