Test for ffi_prep_closure_loc() to make sure we can use this function #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this function since ffi-1.13.0 but didn't test for it. It seems that MacOS 10.14 ships a libffi which is missing this function (older than 11 years). On the other hand we don't use ffi_closure_alloc() any longer. Fixes ffi#785
Closed
ChrisBAshton
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Jun 23, 2020
Build fails with: ``` dyld: lazy symbol binding failed: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib dyld: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib [1] 66481 abort GITHUB_TOKEN=$(cat ~/github_token.txt) NO_CONTRACTS=true bundle exec middlema ``` Downgrading to lower version fixes it. It looks as though this should have been fixed in ffi/ffi#787, but we're seeing the same error as originally reported.
ChrisBAshton
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Jun 23, 2020
Build fails with: ``` dyld: lazy symbol binding failed: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib dyld: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib [1] 66481 abort GITHUB_TOKEN=$(cat ~/github_token.txt) NO_CONTRACTS=true bundle exec middlema ``` Downgrading to lower version fixes it. It looks as though this should have been fixed in ffi/ffi#787, but we're seeing the same error as originally reported.
ChrisBAshton
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Jun 24, 2020
Build fails with: ``` dyld: lazy symbol binding failed: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib dyld: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib [1] 66481 abort GITHUB_TOKEN=$(cat ~/github_token.txt) NO_CONTRACTS=true bundle exec middlema ``` Downgrading to lower version fixes it. It looks as though this should have been fixed in ffi/ffi#787, but we're seeing the same error as originally reported.
ChrisBAshton
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Jun 24, 2020
Build fails with: ``` dyld: lazy symbol binding failed: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib dyld: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib [1] 66481 abort GITHUB_TOKEN=$(cat ~/github_token.txt) NO_CONTRACTS=true bundle exec middlema ``` Downgrading to lower version fixes it. It looks as though this should have been fixed in ffi/ffi#787, but we're seeing the same error as originally reported.
ChrisBAshton
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Aug 3, 2020
This reverts commit 6ec898a and brings us back to commit 9bc604e, where we explicitly opted in to version 1.12.0 of ffi. The reason being, there is a known issue with OSX that leads to the following build error: ``` dyld: lazy symbol binding failed: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib dyld: Symbol not found: _ffi_prep_closure_loc Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle Expected in: /usr/lib/libffi.dylib [1] 66481 abort GITHUB_TOKEN=$(cat ~/github_token.txt) NO_CONTRACTS=true bundle exec middlema ``` Downgrading to lower version fixes it. It looks as though this should have been fixed in ffi/ffi#787, but we're seeing the same error as originally reported. In the next commit I will add a Dependabot config which will prevent a bump PR from being raised again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this function since ffi-1.13.0 but didn't test for it.
It seems that MacOS 10.14 ships a libffi which is missing this function (older than 11 years).
On the other hand we don't use ffi_closure_alloc() any longer.
Fixes #785