Skip to content

Commit

Permalink
Revert "build(deps): bump ffi from 1.12.0 to 1.13.1"
Browse files Browse the repository at this point in the history
This reverts commit 6ec898a and
brings us back to commit 9bc604e,
where we explicitly opted in to version 1.12.0 of ffi.

The reason being, there is a known issue with OSX that leads to
the following build error:

```
dyld: lazy symbol binding failed: Symbol not found: _ffi_prep_closure_loc
  Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle
  Expected in: /usr/lib/libffi.dylib

dyld: Symbol not found: _ffi_prep_closure_loc
  Referenced from: /Users/christopherashton/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle
  Expected in: /usr/lib/libffi.dylib

[1]    66481 abort      GITHUB_TOKEN=$(cat ~/github_token.txt) NO_CONTRACTS=true bundle exec middlema
```

Downgrading to lower version fixes it.
It looks as though this should have been fixed in
ffi/ffi#787, but we're seeing the same
error as originally reported.

In the next commit I will add a Dependabot config which will
prevent a bump PR from being raised again.
  • Loading branch information
ChrisBAshton committed Aug 3, 2020
1 parent 4535736 commit 1f3cb19
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -4,7 +4,7 @@ ruby File.read(".ruby-version").chomp

gem "activesupport", "~> 5.2"
gem "capybara", "~> 3.33.0"
gem "ffi", "1.13.1"
gem "ffi", "1.12"
gem "rake"
gem "rspec", "~> 3.9"
gem "rubocop-govuk"
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Expand Up @@ -63,7 +63,7 @@ GEM
faraday (~> 1.0)
fast_blank (1.0.0)
fastimage (2.2.0)
ffi (1.13.1)
ffi (1.12.0)
github-markdown (0.6.9)
govuk_schemas (4.1.0)
json-schema (~> 2.8.0)
Expand Down Expand Up @@ -276,7 +276,7 @@ DEPENDENCIES
capybara (~> 3.33.0)
faraday-http-cache (~> 2.2.0)
faraday_middleware (~> 1.0.0)
ffi (= 1.13.1)
ffi (= 1.12)
github-markdown
govuk_schemas (~> 4.1.0)
govuk_tech_docs
Expand Down

0 comments on commit 1f3cb19

Please sign in to comment.