Skip to content

Commit

Permalink
Remove MACOSX_DEPLOYMENT_TARGET that was targeting very old version 10.4
Browse files Browse the repository at this point in the history 
This should fix the error "ld: library not found for -lgcc_s.10.4"

Fixes #647
  • Loading branch information
@larskanis
larskanis committed Oct 10, 2019
1 parent 8bcf60b commit 6e631e0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion ext/ffi_c/libffi.darwin.mk
View file
Expand Up @@ -58,7 +58,7 @@ build_ffi = \
env CC="$(CCACHE) $(CC)" CFLAGS="-arch $(1) $(LIBFFI_CFLAGS)" LDFLAGS="-arch $(1)" \
$(LIBFFI_CONFIGURE) --host=$(1)-apple-darwin > /dev/null; \
fi); \
env MACOSX_DEPLOYMENT_TARGET=10.4 $(MAKE) -C "$(BUILD_DIR)"/libffi-$(1)
$(MAKE) -C "$(BUILD_DIR)"/libffi-$(1)

target_ffi = "$(BUILD_DIR)"/libffi-$(1)/.libs/libffi_convenience.a:; $(call build_ffi,$(1))

Expand Down
2 changes: 0 additions & 2 deletions spec/ffi/fixtures/GNUmakefile
View file
Expand Up @@ -23,8 +23,6 @@ PREFIX = lib
LIBEXT ?= so
LIBNAME = $(PREFIX)test.$(LIBEXT)

export MACOSX_DEPLOYMENT_TARGET=10.4

CCACHE := $(strip $(realpath $(shell which ccache 2> /dev/null)))

TEST_SRCS = $(wildcard $(SRC_DIR)/*.c)
Expand Down

2 comments on commit 6e631e0

@stevecheckoway
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You applied my patch which fixes the build error but, from the comments, isn't sufficient to actually make ffi work on macOS.

@larskanis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevecheckoway Can you please open a new ticket, with logs of the issue? Unfortunately I can not reproduce the issues locally, since my only Mac-System is the Travis-CI platform and it is running fine. So I really appreciate pull requests to fix the situation on MacOS.

Please sign in to comment.