Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Luhn algorithm used in french companie's SIRET and sweden SSN #548

Merged
merged 2 commits into from Apr 8, 2024

Conversation

Krap
Copy link
Contributor

@Krap Krap commented Mar 28, 2024

Fixed implementation for the Luhn checksum algorithm (implementation was wrong, and examples in reference where all invalid).

@Krap
Copy link
Contributor Author

Krap commented Mar 28, 2024

Sorry, forgot about rubocop. Done.

Copy link
Member

@marocchino marocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marocchino marocchino merged commit 3676ce1 into ffaker:main Apr 8, 2024
5 checks passed
@marocchino
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants