Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used
FFaker::Guid.guid
and realized it can produce invalid UUIDs: UUIDs can’t be arbitrary data; bits 48–51 and 64–65 must have predefined values. Rather than changeGuid.guid
to produce a valid UUID, I’ve deprecated it and replaced it with more-specificUUID.uuidv4
,.uuidv6
,.uuidv7
, and.uuidv8
methods. These follow the specification (which is still being worked on, but close to approval — current draft).from
,to
arguments likeDate.between
. I decided it wasn’t necessary, though it might be useful for testing code that relies on those versions’ behavior of putting the slowest-changing part of the timestamp at the start of the UUID. (For example, a trie.)