Constrain BankUS.routing_number's first two digits #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
professor
force-pushed
the
ts/limit-us-bank-rounting
branch
2 times, most recently
from
fa912d0
to
fec422b
Compare
marocchino
reviewed
Sep 19, 2023
marocchino
reviewed
Sep 19, 2023
marocchino
reviewed
Sep 19, 2023
Co-authored-by: marocchino <marocchino@users.noreply.github.com>
Co-authored-by: marocchino <marocchino@users.noreply.github.com>
professor
force-pushed
the
ts/limit-us-bank-rounting
branch
from
7593054
to
485046f
Compare
marocchino
reviewed
Sep 19, 2023
professor
force-pushed
the
ts/limit-us-bank-rounting
branch
from
8f5b771
to
542c13e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mea Culpa! I went to use
BankUS.routing_numberwith our application and had 100s of test failures. Today, I learned that the first two numbers need to be within a certain range.Before submitting this PR, I have tested the code in my application and can confirm that there were no errors in our gazillions of tests.
I would like feedback on the implementation, e.g. sample.