New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend from within fix #249

Open

lucasallison wants to merge 1 commit into ferrilab:main from lucasallison:extend_from_within_fix

lucasallison commented Nov 7, 2023

Changed the assert_within_bounds in the extend_from_within function to allow ranges that include the last element of the vector.

Currently when calling ranges that include the the last element of the bit vector the code panics, for example:

let mut b = bitvec![0; 2];
b.extend_from_within(..);

Yields:

thread 'main' panicked at 'index 2 out of range: Excluded(2)

Editing the range in the assert will not panic on such ranges.


          Changed the assert_within_bounds in the extend_from_within functi…

449007f

…on to allow ranges that include the last element of the vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment