Spin core refactor #763

lann · 2022-09-13T17:45:31Z

This refactors Spin to use the new spin-core and spin-app crates that we've been developing in an internal prototype.

With a few small exceptions I have attempted to not change the visible behavior of spin up, but with so many updates I'm sure I've missed some things.

There are thousands of lines of changes here, so I've tried to split things up into reasonable commits for those who prefer to review that way.

crates/app/src/lib.rs

crates/app/src/values.rs

dicej

Looks good to me. Thanks for taking on this huge effort!

Mossaka · 2022-09-15T06:05:25Z

This looks great to me! I especially love the design of DynamocHostComponent that can update host components' data in runtime (whene http request comes in), and the design of LockedComponent.

I do wonder why do you decide to impl allowed_http_hosts as dynamic data in http. I thought this variable is statically decalred in spin.toml manifest file, and thus can be added to HostComponent Data before runtime. No?

In addition, what is the use cases of spin.lock?

lann · 2022-09-15T13:08:43Z

@Mossaka:

I do wonder why do you decide to impl allowed_http_hosts as dynamic data in http. I thought this variable is statically decalred in spin.toml manifest file, and thus can be added to HostComponent Data before runtime. No?

HostComponent Data is currently constructed per-request, not at startup. Preinitialization of some data would be possible but I don't see much benefit for the current set of host components.

In addition, what is the use cases of spin.lock?

One purpose is to provide a more stable interface between spin up and trigger executors, which should simplify the implementation of trigger executor plugins (see also #735).

crates/app/src/lib.rs

crates/core/src/host_component.rs

radu-matei · 2022-09-27T15:46:10Z

Have switched to this branch as the Spin binary I am using on a daily basis, and I am hitting the error below when trying to run https://github.com/coderoflagos/bartholomew-sample.

Rendering "/content/index.md": Capabilities insufficient (os error 76)

lann · 2022-09-27T16:49:27Z

Have switched to this branch as the Spin binary I am using on a daily basis, and I am hitting the error below when trying to run https://github.com/coderoflagos/bartholomew-sample.

Rendering "/content/index.md": Capabilities insufficient (os error 76)

Bartholomew tries to create a cache file: https://github.com/fermyon/bartholomew/blob/c602220ee4da6b2a22b17f0b04ff8eba1b8adc75/src/content.rs#L133

Looks like Spin currently allows writing new files even without --allow-transitent-write

lann · 2022-09-27T20:15:05Z

Bartholomew issue should be fixed in fermyon/bartholomew#135

Signed-off-by: Lann Martin <lann.martin@fermyon.com>

This will replace spin-trigger in a future commit. Signed-off-by: Lann Martin <lann.martin@fermyon.com>

Signed-off-by: Lann Martin <lann.martin@fermyon.com>

It isn't clear why this was included in the first place and it doesn't appear to be used now. Signed-off-by: Lann Martin <lann.martin@fermyon.com>

Also add AppComponent::require_metadata for interface consistency. Signed-off-by: Lann Martin <lann.martin@fermyon.com>

Signed-off-by: Lann Martin <lann.martin@fermyon.com>

The new trigger code expects the working directory to be absolute, which is the case for tempdirs but not necessarily `--temp`. Fix by `.canonicalize()`ing the work dir. Signed-off-by: Lann Martin <lann.martin@fermyon.com>

radu-matei

I've been using a build from this branch as my main Spin binary for a while now and everything appears to be in order.

As we start working on various parts of the codebase, I am sure we will start finding small bits that we can improve, but overall, the improvements in this PR are great!

Thank you!

LGTM

Refs: fermyon#763. Signed-off-by: Konstantin Shabanov <mail@etehtsea.me>

Fixes the following error: $ spin build up --follow-all <..> Successfully ran the build command for the Spin components. Error: Failed to configure Redis trigger Caused by: metadata error: missing required "redis_address" Error: exit status: 1 Refs: fermyon#763. Signed-off-by: Konstantin Shabanov <mail@etehtsea.me>