fix: Upgrade clap and suppress clippy error #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Apr 27, 2023
Clap generated code was broken by a new clippy warning in Rust 1.69. This was partially fixed in clap 3.2.24 along with a clippy exception. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
fix-clippy-clap-cataclysm
branch
from
281211a
to
90cbfaf
Compare
rylev
approved these changes
Apr 27, 2023
|
I'm bypassing the e2e CI failure; its known and this fix is (also) needed for builds to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap generated code was broken by a new clippy warning in Rust 1.69. This was partially fixed in clap 3.2.24 along with a clippy exception.
Ref: clap-rs/clap#4857