Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release.yml): fetch tags to fix canaryExists logic #66

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

vdice
Copy link
Member

@vdice vdice commented Aug 17, 2023

Previously, tags weren't actually fetched, throwing off the canaryExists logic.

Interestingly, tags still won't be fetched when fetch-depth is > 0 (as is the default, being 1), even when toggling fetch-tags: true on the checkout action. (See actions/checkout#701).

Therefore, I just add a git fetch --prune --unshallow --tags to start the step. (Prefer not to set fetch-depth to 0 and thus fetch all git history.)

Depends on #64 (will convert from Draft once merged)

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice marked this pull request as ready for review August 18, 2023 18:11
@vdice vdice requested a review from karthik2804 August 18, 2023 18:11
@vdice vdice merged commit a653f80 into fermyon:main Aug 18, 2023
8 checks passed
@vdice vdice deleted the ci/fix-canary-exists branch August 18, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants