Skip to content
This repository has been archived by the owner on Sep 11, 2021. It is now read-only.

Upgrade from Python 2.7.17 --> 3.8.1 #205

Merged
merged 7 commits into from
Jan 7, 2020
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 5, 2020

README.md Outdated Show resolved Hide resolved
@jacobq
Copy link
Collaborator

jacobq commented Jan 6, 2020

Thanks so much for submitting a PR (just peeked at this and #204)! This project has been pretty dormant lately so I'm happy to see some activity.

appveyor.yml Outdated Show resolved Hide resolved
@cclauss cclauss changed the title Upgrade from Python 2.7.15 --> 3.8.1 Upgrade from Python 2.7.17 --> 3.8.1 Jan 6, 2020
@cclauss
Copy link
Contributor Author

cclauss commented Jan 6, 2020

I also believe that Visual Studio 2019 is now supported and VS2015 is not so perhaps the beta should step up there as well.

@jacobq
Copy link
Collaborator

jacobq commented Jan 6, 2020

Do you happen to know if support for Windows 7 has been dropped? It'd be nice to have a link to that info as well since there are still numerous users running on versions of Windows older than Windows 10.

@jacobq
Copy link
Collaborator

jacobq commented Jan 6, 2020

As it stands right now, this PR appears to basically just bump numbers and update a link in the README. Unless there are objections, I plan to rebase/squash and merge this once it's clear/documented how compatibility is affected -- i.e. which versions of NodeJS and Windows are supported. Then we can update to VS2019 and attempt a beta release (might need @felixrieseberg to help with that).

@jacobq jacobq self-assigned this Jan 6, 2020
@jacobq jacobq added dependencies Pull requests that update a dependency file enhancement labels Jan 6, 2020
@sam-github
Copy link

@jacobq Win7 still supported, see platform support: https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list

Use the branch dropdown to compare to various node.js releases if wanted, for example: v12.x is https://github.com/nodejs/node/blob/v12.x/BUILDING.md#platform-list

@jacobq
Copy link
Collaborator

jacobq commented Jan 6, 2020

@jacobq Win7 still supported...

Thanks; that covers the NodeJS portion. When we do the VS2019 update we'll need to check compatibility for that also.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 6, 2020

@jacobq nodejs/node#25789 (comment) should help clarify some things.

@sam-github and I discussed and we think your beta idea (mentioned above) is great.

@jacobq jacobq merged commit 676db3e into felixrieseberg:master Jan 7, 2020
@cclauss cclauss deleted the Python3 branch January 7, 2020 18:00
@cclauss
Copy link
Contributor Author

cclauss commented Jul 10, 2020

@felixrieseberg Can we please get a release of the current codebase uploaded into npm?

@aminya aminya mentioned this pull request Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 2.7.16 installed already, installs 2.7.15 anyways
4 participants