Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed misleading comment on _registerMatcher #101

Merged
merged 1 commit into from Dec 28, 2021
Merged

docs: Fixed misleading comment on _registerMatcher #101

merged 1 commit into from Dec 28, 2021

Conversation

mousedownmike
Copy link
Contributor

if named is null, arguments are stored as positional, comment previously stated non-null instead of null

Status

READY

Breaking Changes

NO

Description

Very minor change to the text of a comment on _registerMatcher but it significantly changes the meaning.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

if named is null arguments are stored as positional, comment previously stated non-null
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contribution! πŸ’―πŸŽ‰

@felangel felangel merged commit c9471cb into felangel:main Dec 28, 2021
@felangel felangel added the documentation Improvements or additions to documentation label Dec 28, 2021
@mousedownmike mousedownmike deleted the feature/registerMatcher_comment branch December 28, 2021 01:31
@felangel felangel mentioned this pull request Mar 1, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants