-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate recase
and include pascalDotCase
#840
Merged
felangel
merged 10 commits into
felangel:master
from
LukeMoody01:feature/move-recase-to-mason
Apr 5, 2023
Merged
feat: integrate recase
and include pascalDotCase
#840
felangel
merged 10 commits into
felangel:master
from
LukeMoody01:feature/move-recase-to-mason
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
previously approved these changes
Mar 27, 2023
felangel
changed the title
feat: Add recase and pascalDotCase
feat: integrate Apr 3, 2023
recase
and include pascalDotCase
felangel
reviewed
Apr 3, 2023
felangel
reviewed
Apr 3, 2023
felangel
reviewed
Apr 3, 2023
felangel
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks so much for the contribution! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
This PR adds support for additional string casing styles, specifically Title.Case (PascalDotCase) #706 , to the Mason package. As ReCase is no longer maintained (My PR has been open for quite a while), I have moved the package over to mason and documented the class. I have updated the corresponding string extensions and render functions to support the new format.
Let me know if there are any issues with this approach! I also feel this could give developers the options to override / create their own LambdaFunctions which would be cool!