Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mason): git brick install across file systems #832

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

felangel
Copy link
Owner

@felangel felangel commented Mar 24, 2023

Status

READY

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working label Mar 24, 2023
@felangel felangel self-assigned this Mar 24, 2023
@@ -12,6 +12,10 @@ class _MockLogger extends Mock implements Logger {}

void main() {
group('MasonGenerator', () {
final identicalString = ' ${cyan.wrap('identical')} ';
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were acting a bit flaky so I made them a bit more strict which seemed to help

@felangel felangel merged commit 1d48caf into master Mar 24, 2023
@felangel felangel deleted the fix/mason-git-clone-across-file-systems branch March 24, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: FileSystemException on mason get
1 participant