Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove deprecated .packages #512

Merged
merged 2 commits into from Sep 8, 2022
Merged

ci: remove deprecated .packages #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557b7c9
ci: remove deprecated .packages
felangel Sep 8, 2022
6f374af
chore(mason): remove redundant args
felangel Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mason.yaml
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Run Tests
run: |
dart pub global activate coverage 1.2.0
dart test -j 1 -x pull-request-only --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
dart test -j 1 -x pull-request-only --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib

- name: Check Code Coverage
uses: VeryGoodOpenSource/very_good_coverage@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mason_api.yaml
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Run Tests
run: |
dart pub global activate coverage 1.2.0
dart test --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
dart test --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib

- name: Check Code Coverage
uses: VeryGoodOpenSource/very_good_coverage@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mason_cli.yaml
View file
Open in desktop
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: Run Tests
run: |
dart pub global activate coverage 1.2.0
dart test -j 1 -x pull-request-only --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
dart test -j 1 -x pull-request-only --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib

- name: Check Code Coverage
uses: VeryGoodOpenSource/very_good_coverage@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mason_logger.yaml
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Run Tests
run: |
dart pub global activate coverage 1.2.0
dart test --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
dart test --coverage=coverage && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib

- name: Check Code Coverage
uses: VeryGoodOpenSource/very_good_coverage@v1
Expand Down
1 change: 0 additions & 1 deletion packages/mason/lib/src/compute.dart
View file
Open in desktop
Expand Up @@ -9,7 +9,6 @@ Future<R> compute<R, M>(FutureOr<R> Function(M) computation, M input) async {
await Isolate.spawn<_IsolateConfig<M, FutureOr<R>>>(
_spawn,
_IsolateConfig<M, FutureOr<R>>(computation, input, resultPort.sendPort),
errorsAreFatal: true,
onError: errorPort.sendPort,
);

Expand Down