Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mason_logger): remove deprecated methods in WindowsTerminal #1286

Merged
merged 1 commit into from
Apr 4, 2024
Merged

refactor(mason_logger): remove deprecated methods in WindowsTerminal #1286

merged 1 commit into from
Apr 4, 2024

Conversation

felangel
Copy link
Owner

@felangel felangel commented Apr 4, 2024

Status

READY

Description

  • refactor(mason_logger): remove deprecated methods in WindowsTerminal

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the refactor Refactor an existing implementation label Apr 4, 2024
@felangel felangel self-assigned this Apr 4, 2024
@felangel felangel merged commit b9dfd9f into master Apr 4, 2024
14 checks passed
@felangel felangel deleted the refactor/remove-deprecated-methods branch April 4, 2024 05:35
@lkervran lkervran mentioned this pull request Apr 19, 2024
Closed
@renefloor
Copy link

@felangel This change requires win32 5.4.0, but the pubspec sets the minimum to 5.0.7.
As 5.3.0 requires Dart 3.3.0 everybody that's not yet on Flutter 3.19.0 or newer will resolve the latest mason_logger with an incompatible version of win32.

I think it's best to revert this change, publish that as 0.2.14 so everybody automatically gets the latest that works, and then apply it again with the correct minimum version of win32 as 0.2.15.

felangel added a commit that referenced this pull request Apr 19, 2024
@felangel
Revert "refactor(mason_logger): remove deprecated methods in `Windows…
e17ddee 
…Terminal` (#1286)"

This reverts commit b9dfd9f.
felangel added a commit that referenced this pull request Apr 19, 2024
@felangel
fix(mason_logger): revert "remove deprecated methods in `WindowsTermi…
c7817cf 
…nal`" (#1299)

* Revert "fix(mason_logger): The getter 'STD_HANDLE' isn't defined for the class 'WindowsTerminal' (#1298)"

This reverts commit 6b6d30c.

* Revert "refactor(mason_logger): remove deprecated methods in `WindowsTerminal` (#1286)"

This reverts commit b9dfd9f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felangel felangel

Labels
refactor Refactor an existing implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felangel @renefloor