feat(mason_cli): mason make --watch

[alestiago]

Status

READY FOR REVIEW

Description

Partially resolves #384

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[alestiago]

Drafted, investigating Windows hang.

[alestiago]

This Pull Request is ready to be reviewed. The Windows hang mentioned previously (#1131 (comment)) was fixed (commit f222430).

---

If you would like to test the change you may:

1. Clone my mason fork:

git clone https://github.com/alestiago/mason.git

2. Checkout to the alestiago:alestiago/mason-watch-flag branch.

3. Install a local version of mason_cli (from packages/mason_cli):

dart pub global activate --source path .

4. Try it out by making a new local brick and using the --watch flag.

[felangel]

I started reviewing yesterday. Will try to wrap up today or tomorrow. One thing to consider is this implementation doesn’t handle the case where I remove a file from the brick as the output will remain polluted with the previous run’s output for that file. Also the default behavior seems weird because you’ll always have conflicts with watch mode so the default prompting behavior doesn’t work well imo 🤷‍♂️

[alestiago]

I started reviewing yesterday. Will try to wrap up today or tomorrow.

Awesome, thank you for taking a look. Feel free to apply changes as you desire.

One thing to consider is this implementation doesn’t handle the case where I remove a file from the brick as the output will remain polluted with the previous run’s output for that file.

That is true and is a valid observation! I think implementing such case would require taking snapshots of the output directory. We should for example, not delete a file that was already there before the make command. However, I think we could introduce this functionality as another Pull Request.

Also the default behavior seems weird because you’ll always have conflicts with watch mode so the default prompting behavior doesn’t work well imo

Definitely! Personally, every time I use the --watch argument I specify a configuration file to avoid the prompts. As a bonus, by updating the configuration file I get new makes with whatever variables I changed. In addition, I almost always use --on-conflict overwrite when using --watch.

I didn't commit to solving the "prompting" issue since it would be highly opinionated and require an agreement on how to resolve so. Maybe, we could resolve this as another Pull Request? Since it's already solvable by using a configuration file?

[felangel]

Thanks so much for the contribution! 💙