Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mason_cli): refactor setUp in make_test.dart #1130

Merged
merged 6 commits into from
Nov 1, 2023
Merged

test(mason_cli): refactor setUp in make_test.dart #1130

merged 6 commits into from
Nov 1, 2023

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Oct 26, 2023 •
edited

Status

READY

Description

Refactors the setup method of make_test.dart

Changes:

  • Dynamically creates the content of mason.yaml and bricks.json
  • Ensures mason.yaml and bricks.json are cleaned up (deleted)

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago marked this pull request as draft October 26, 2023 13:33
@alestiago alestiago marked this pull request as ready for review October 26, 2023 13:35
@alestiago alestiago changed the title test(mason_cli): clean make setUp test(mason_cli): refactor make setUp Oct 26, 2023
@felangel felangel changed the title test(mason_cli): refactor make setUp test(mason_cli): refactor setUp in make_test.dart Nov 1, 2023
@felangel felangel added tests changes to tests refactor Refactor an existing implementation labels Nov 1, 2023
felangel
felangel approved these changes Nov 1, 2023
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor simplifications to both address your original goal while sticking closer to the original implementation, thanks! LGTM ✅

@felangel felangel merged commit c2746f9 into felangel:master Nov 1, 2023
7 checks passed
@alestiago alestiago deleted the alestiago/refactor-mason-make-setup branch November 1, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@alestiago alestiago

Labels
refactor Refactor an existing implementation tests changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alestiago @felangel