Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use SplayTreeSet to resolve inconsistent hashCode #142

Merged
merged 5 commits into from Aug 19, 2022
Merged

fix: use SplayTreeSet to resolve inconsistent hashCode #142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb1508a
uses SplayTreeSet to be independent of the insertion order of a Set f…
devmil Jul 28, 2022
c12ac2d
Update lib/src/equatable_utils.dart
felangel Aug 3, 2022
2e40280
updates workflow to echo pana output in case score is too low
devmil Aug 3, 2022
a3d847a
Merge branch 'master' into bugfix/set_equality
felangel Aug 18, 2022
6525cf7
Check if the given Set is already a SplayTreeSet
devmil Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/src/equatable_utils.dart
View file
Open in desktop
@@ -1,3 +1,5 @@
import 'dart:collection';

import 'package:collection/collection.dart';
import 'package:equatable/equatable.dart';

Expand Down Expand Up @@ -46,6 +48,11 @@ int _combine(int hash, dynamic object) {
});
return hash;
}
if(object is Set) {
felangel marked this conversation as resolved.
Show resolved Hide resolved
// this is needed to have a consistent iteration order so that the produced
// hash is consistent independently of the Set insertion order
object = SplayTreeSet<dynamic>.from(object);
}
if (object is Iterable) {
for (final value in object) {
hash = hash ^ _combine(hash, value);
Expand Down
11 changes: 11 additions & 0 deletions test/equatable_test.dart
View file
Open in desktop
Expand Up @@ -968,6 +968,17 @@ void main() {
expect(instanceA.hashCode == instanceB.hashCode, true);
});

test('should return when Set values are same but in different order', () {
final instanceA = SimpleEquatable<Set<String>>(
Set.from(<String>['A', 'B']),
);
final instanceB = SimpleEquatable<Set<String>>(
Set.from(<String>['B', 'A']),
);
expect(instanceA == instanceB, true);
expect(instanceA.hashCode == instanceB.hashCode, true);
});

test('should return when values are different', () {
final instanceA = SimpleEquatable<Set<String>>(
Set.from(<String>['A', 'B']),
Expand Down