fix: use SplayTreeSet to resolve inconsistent hashCode #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or generating hashes
felangel
reviewed
Aug 3, 2022
felangel
reviewed
Aug 18, 2022
felangel
changed the title
Co-authored-by: Felix Angelov <felangelov@gmail.com>
|
@devmil thanks for the contribution! I’ll merge and publish this tomorrow 👍 |
felangel
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
Status
READY
Breaking Changes
NO
Description
This fixes the inconsistent hashCode behaviour for Sets by using a SplayTreeSet to ensure a consistent iteration order.
Todos
Steps to Test or Reproduce
See #141
Impact to Remaining Code Base
None known