Use native connection checks where possible and with configurable timout #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomiguelabreu
requested review from
leitaop,
jmf-tls,
artpdr,
joaonuno,
marpereira and
smmf
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
2 times, most recently
from
bdd1c5b
to
078f3ee
Compare
hugomiguelabreu
changed the title
checkConnection executes with a configurable timeout
hugomiguelabreu
changed the title
checkConnection executes with a configurable timeout
hugomiguelabreu
changed the title
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
3 times, most recently
from
b4599da
to
9098fbd
Compare
artpdr
reviewed
Oct 21, 2020
src/main/java/com/feedzai/commons/sql/abstraction/engine/AbstractDatabaseEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/feedzai/commons/sql/abstraction/engine/AbstractDatabaseEngine.java
Show resolved
Hide resolved
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
9098fbd
to
1fa3459
Compare
|
UT are all good to go. |
artpdr
reviewed
Oct 21, 2020
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/MySqlEngine.java
Outdated
Show resolved
Hide resolved
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
1fa3459
to
21acb01
Compare
artpdr
reviewed
Oct 21, 2020
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/OracleEngine.java
Outdated
Show resolved
Hide resolved
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
2 times, most recently
from
0781e1c
to
7ec396d
Compare
artpdr
reviewed
Oct 21, 2020
src/main/java/com/feedzai/commons/sql/abstraction/engine/AbstractDatabaseEngine.java
Outdated
Show resolved
Hide resolved
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
7ec396d
to
ddfafbc
Compare
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
ddfafbc
to
e2f1ca3
Compare
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
e2f1ca3
to
c6fa3c1
Compare
|
DB2 using |
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
2 times, most recently
from
e019069
to
c619f44
Compare
artpdr
reviewed
Oct 22, 2020
src/main/java/com/feedzai/commons/sql/abstraction/engine/impl/DB2Engine.java
Outdated
Show resolved
Hide resolved
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
7 times, most recently
from
6347ce7
to
b2739d8
Compare
jmf-tls
reviewed
Oct 23, 2020
src/main/java/com/feedzai/commons/sql/abstraction/engine/AbstractDatabaseEngine.java
Outdated
Show resolved
Hide resolved
src/test/java/com/feedzai/commons/sql/abstraction/engine/impl/abs/TimeoutsTest.java
Outdated
Show resolved
Hide resolved
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
b2739d8
to
feecf43
Compare
jmf-tls
approved these changes
Oct 23, 2020
hugomiguelabreu
force-pushed
the
ft-ha-check-connection
branch
from
feecf43
to
4db3646
Compare
hugomiguelabreu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces changes to the verification of the JDBC connections.
When verifying database connections, PDB should do it in a timely manner to allow a faster failover of the database. To achieve this goal, a new property is included to configure the timeout of the verification.
Most of the engines are now using JDBC standard
isValid().PostgreSQL, do not respect it and unit tests had failed consistently. (see: pgjdbc/pgjdbc#1943)
DB2 does not correctly recover connections using
isValid().