Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quick xml #156

Merged
merged 4 commits into from Sep 27, 2022
Merged

Update quick xml #156

merged 4 commits into from Sep 27, 2022

Commits on Sep 27, 2022

  1. Upgrade to quick-xml 0.25

    @davidcornu @markpritchard
    davidcornu authored and markpritchard committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    bf2a5cd View commit details
    Browse the repository at this point in the history

  2. Return None instead of calling .unwrap() to skip invalid attributes

    @davidcornu @markpritchard
    davidcornu authored and markpritchard committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7090ebf View commit details
    Browse the repository at this point in the history

  3. Skip CData that can't be escaped rather than bubbling the error

    @davidcornu @markpritchard
    davidcornu authored and markpritchard committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5f4e55f View commit details
    Browse the repository at this point in the history

  4. Minor tweak after quick-xml upgrade 

    - map unknown namespaces to default (else we just fail when trying
  to parse them)
- move the unescape/decode inside the check so we avoid doing it when
  the text is empty
    @markpritchard
    markpritchard committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b385509 View commit details
    Browse the repository at this point in the history