Upgrade to quick-xml 0.25 #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcornu
commented
Sep 23, 2022
|
Fixed in #156 |
|
(sorry my github foo is poor, not sure how to add commits to your branch before merge) |
|
No worries! Thanks for the feedback and merging the fix ❤️. I'll keep an eye out for a release so I can remove my git dependency. |
|
Yep, the release is done ;)
…On Tue, 27 Sept 2022 at 21:43, David Cornu ***@***.***> wrote:
No worries! Thanks for the feedback and merging the fix ❤️.
I'll keep an eye out for a release so I can remove my git dependency.
—
Reply to this email directly, view it on GitHub
<#153 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB62IVUAC7L3KFV7ZGCB7EDWALMWXANCNFSM6AAAAAAQUFQX4Q>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the same side-project as #151, I also ran into an issue where some seemingly-valid feeds would fail to parse.
For example,
https://blog.pnkfx.org/atom.xmlresults in:I believe this is related to a recently-fixed issue in
quick-xmlso decided to upgrade the version used byfeed-rs, which has fixed my issue.