fix(jit-values): they can actually get canceled #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsirion
approved these changes
May 16, 2024
| if err.is_cancelled() { | ||
| warn!(target: LOG_TASK, %err, type_name = %std::any::type_name::<T>(), "Jit value task canceled:"); | ||
| } | ||
| panic!("Jit value {} failed unexpectedly with: {}", std::any::type_name::<T>(), err); |
There was a problem hiding this comment.
Took me way too long to find that diff 😆 would have been nice if the pure refactoring was a separate PR, or at least if there was a comment pointing to the actual change 🙈
There was a problem hiding this comment.
Oh. The whole outside thing had to change due needing to return some value. So there's no smaller way that would compile (that I could come up with at least).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leading to panics on shutdown sometimes.