chore(deps): update lightning and lightning-invoice #5265
Conversation
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This one keeps flaking |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
tvolk131
force-pushed
the
update_lightning
branch
from
5cd8be7
to
37af160
Compare
Cargo.toml
Outdated
| lightning = { version = "0.0.123", default-features = false, features = ["no-std"] } | ||
| lightning-invoice = { version = "0.31.0", default-features = false, features = ["no-std"] } |
There was a problem hiding this comment.
I don't think we can use no-std for everything, that's the cause of the CI failures. @TonyGiorgio @benthecarman I remember you weren't fans of it anyway and we just have to be careful not to use functionality not supported in WASM.
There was a problem hiding this comment.
yeah, IIRC lightning in no-std requires bitcoin in no-std and that breaks a lot of things. This patch of LDK has been working well for us, unfortunately LDK does not want to merge such a thing until they can upstream things to rust-bitcoin and allow no-std to have better compatibility.
There was a problem hiding this comment.
Gotcha, thanks for the clarification! I'll remove the no-std
tvolk131
force-pushed
the
update_lightning
branch
from
37af160
to
70cc86b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
tvolk131
force-pushed
the
update_lightning
branch
from
70cc86b
to
7410a50
Compare
|
Needs a rebase. Ping me when you need it landed @tvolk131 |
tvolk131
force-pushed
the
update_lightning
branch
from
7410a50
to
d15bb73
Compare
No description provided.