Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: basic gateway devimint config test #5231

Merged
merged 1 commit into from
May 17, 2024

Conversation

m1sterc001guy
Copy link
Contributor

@m1sterc001guy m1sterc001guy commented May 7, 2024

Builds on #5233

Part of #5168

Removes two tests from integration_tests.rs in the gateway and re-writes them as devimint tests. LND and CLN can be run in parallel. More functionality will be added to these tests over time (to amortize the cost of setting up a all of the daemons).

@m1sterc001guy m1sterc001guy requested review from a team as code owners May 7, 2024 23:44
@m1sterc001guy m1sterc001guy force-pushed the gw_devimint_tests branch 2 times, most recently from fabc45f to 56c8695 Compare May 8, 2024 02:23
@m1sterc001guy m1sterc001guy marked this pull request as draft May 8, 2024 04:11
@m1sterc001guy m1sterc001guy marked this pull request as ready for review May 8, 2024 05:51
dpc
dpc previously approved these changes May 10, 2024
@dpc
Copy link
Contributor

dpc commented May 10, 2024

Rebase needed and doesn't compile.

dpc
dpc previously approved these changes May 14, 2024
@m1sterc001guy m1sterc001guy added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@m1sterc001guy
Copy link
Contributor Author

Something is still flaky about the new test, I am debugging

@m1sterc001guy
Copy link
Contributor Author

Something is still flaky about the new test, I am debugging

Leave fed isn't backwards compatible so I had to remove that for older tests, otherwise this is good to go.

@dpc dpc added this pull request to the merge queue May 17, 2024
Merged via the queue into fedimint:master with commit e0389b6 May 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants