-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: minimal mainnet fedimintd docker setup #5042
Conversation
{ | ||
"<federation_id_hex>": { | ||
"federation_name": "Override Federation Name" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: generate that file automatically once the federation is set up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to land this change before merge or add a TODO for a follow up PR? @elsirion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking about it a bit more: it's not bad enough UX to worry about given that we are phasing out meta override files anyway
Sorry thought I opened up the PR for it, this is covered in my new docker installer |
16c8d56
to
25f5441
Compare
I think it makes sense to keep this PR as a simpler alternative to #5043, requires more DevOps skills to run but is easier to understand and adapt imo (and less error prone). |
kk, if you mark it ready we can merge and I'll update docker deployer off it |
@Kodylow @TonyGiorgio Could one of you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, though a few different competing docker PR's at this point.
I'm more than likely going to close mine (#4269) and maintain it elsewhere. I have a preference towards it and it has worked flawlessly on many occasions. I don't know what the long term plan for making deployments easier, but I like that a minimum example is here.
Addressing my own comment #4872 (review). FYI @Kodylow @TonyGiorgio to avoid duplicate work.