Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimal mainnet fedimintd docker setup #5042

Merged
merged 1 commit into from
May 27, 2024

Conversation

elsirion
Copy link
Contributor

Addressing my own comment #4872 (review). FYI @Kodylow @TonyGiorgio to avoid duplicate work.

@elsirion elsirion added the deployment Running fedimint in the wild label Apr 19, 2024
Comment on lines +1 to +5
{
"<federation_id_hex>": {
"federation_name": "Override Federation Name"
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: generate that file automatically once the federation is set up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to land this change before merge or add a TODO for a follow up PR? @elsirion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about it a bit more: it's not bad enough UX to worry about given that we are phasing out meta override files anyway

@Kodylow
Copy link
Member

Kodylow commented Apr 19, 2024

Sorry thought I opened up the PR for it, this is covered in my new docker installer

@elsirion
Copy link
Contributor Author

I think it makes sense to keep this PR as a simpler alternative to #5043, requires more DevOps skills to run but is easier to understand and adapt imo (and less error prone).

@Kodylow
Copy link
Member

Kodylow commented May 16, 2024

kk, if you mark it ready we can merge and I'll update docker deployer off it

@elsirion elsirion marked this pull request as ready for review May 16, 2024 16:11
@elsirion elsirion requested a review from a team as a code owner May 16, 2024 16:11
@justinmoon
Copy link
Contributor

@Kodylow @TonyGiorgio Could one of you review?

Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though a few different competing docker PR's at this point.

I'm more than likely going to close mine (#4269) and maintain it elsewhere. I have a preference towards it and it has worked flawlessly on many occasions. I don't know what the long term plan for making deployments easier, but I like that a minimum example is here.

@elsirion elsirion added this pull request to the merge queue May 27, 2024
Merged via the queue into fedimint:master with commit fd2b7e8 May 27, 2024
21 checks passed
@elsirion elsirion deleted the 2024-04-docker-mainnet branch May 27, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Running fedimint in the wild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants