chore: preparations for bolt12 support #5020
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschisan
force-pushed
the
lnv2_bolt12
branch
3 times, most recently
from
f714d7a
to
ef768cf
Compare
| #[derive(Debug, Encodable, Decodable)] | ||
| pub struct RegisteredIncomingContract { | ||
| pub federation_id: FederationId, | ||
| pub incoming_amount: u64, |
There was a problem hiding this comment.
IncomingContract has the amount in the Commitment, is this just for convenience?
There was a problem hiding this comment.
Or does this value include fees?
There was a problem hiding this comment.
The two amounts differ by the fee. incoming_amount is higher and is the amount in the invoice.
There was a problem hiding this comment.
Can address in the future but a different name would help IMO
There was a problem hiding this comment.
incoming_htlc_amount?
| pub refund_keypair: KeyPair, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Eq, PartialEq, Hash, Decodable, Encodable)] | ||
| pub enum Invoice { |
There was a problem hiding this comment.
Maybe this should go in the common crate?
There was a problem hiding this comment.
I would not share this for cleaner separation.
m1sterc001guy
previously approved these changes
Apr 23, 2024
|
Please don't merge yet I am still thinking about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.