-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump reqwest to 0.12.4 #4908
base: master
Are you sure you want to change the base?
Conversation
I opened benthecarman/lnurl-rs#20 for |
Looks like merge failed due to a timeout - anyone wanna put it back in the queue? |
might be a real failure |
Apart from a possible real CI failure, we can also update |
d461b52
to
f939e19
Compare
Rebased, updated |
I wasn't able to reproduce the CI failure in #5024, maybe we can just add the increased logging from that branch here so if it fails in the merge queue again we at least lern what that consensus item spam is about? |
f939e19
to
cccb33b
Compare
Needs rebase but otherwise looks like it works |
be6b014
to
9ff5456
Compare
Rebased and CI is passing! |
9ff5456
to
fba4b8b
Compare
c9c6101
to
e9eca4e
Compare
59ad00b
to
5bd7fb4
Compare
Bump everywhere except forfedimint-cli
since it currently useslnurl-rs
v0.4.1 which usesreqwest
v0.11 and causes an error here if we bump it, due to mismatching versions:fedimint/fedimint-cli/src/client.rs
Line 679 in a3b9990
Once a new version oflnurl-rs
is published that usesreqwest
v0.12, we should be able to bump them both together forfedimint-cli
without issueEdit: a new version of
lnurl-rs
has been published and we're now bumpingreqwest
to v0.12.3 across the entire codebase along with bumpinglnurl-rs
from v0.4.1 to v0.5.0