Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump reqwest to 0.12.4 #4908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tvolk131
Copy link
Contributor

@tvolk131 tvolk131 commented Apr 10, 2024

Bump everywhere except for fedimint-cli since it currently uses lnurl-rs v0.4.1 which uses reqwest v0.11 and causes an error here if we bump it, due to mismatching versions:

let async_client = lnurl::AsyncClient::from_client(reqwest::Client::new());

Once a new version of lnurl-rs is published that uses reqwest v0.12, we should be able to bump them both together for fedimint-cli without issue

Edit: a new version of lnurl-rs has been published and we're now bumping reqwest to v0.12.3 across the entire codebase along with bumping lnurl-rs from v0.4.1 to v0.5.0

@tvolk131 tvolk131 marked this pull request as ready for review April 10, 2024 17:26
@tvolk131 tvolk131 requested review from a team as code owners April 10, 2024 17:26
elsirion
elsirion previously approved these changes Apr 12, 2024
@elsirion
Copy link
Contributor

I opened benthecarman/lnurl-rs#20 for reqwest.

maan2003
maan2003 previously approved these changes Apr 12, 2024
@elsirion elsirion added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@tvolk131
Copy link
Contributor Author

Looks like merge failed due to a timeout - anyone wanna put it back in the queue?

@maan2003 maan2003 added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@maan2003
Copy link
Member

might be a real failure

@dpc dpc added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@elsirion
Copy link
Contributor

Apart from a possible real CI failure, we can also update lnurl-rs now and unify the reqwest dependency.

@tvolk131 tvolk131 dismissed stale reviews from maan2003 and elsirion via d461b52 April 15, 2024 14:09
@tvolk131 tvolk131 force-pushed the update_reqwest branch 2 times, most recently from d461b52 to f939e19 Compare April 15, 2024 14:20
@tvolk131
Copy link
Contributor Author

might be a real failure

Apart from a possible real CI failure, we can also update lnurl-rs now and unify the reqwest dependency.

Rebased, updated lnurl-rs, and unified reqwest to v0.12.3 across the codebase! CI is passing again.

maan2003
maan2003 previously approved these changes Apr 16, 2024
@elsirion elsirion added this pull request to the merge queue Apr 16, 2024
elsirion
elsirion previously approved these changes Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@elsirion
Copy link
Contributor

I wasn't able to reproduce the CI failure in #5024, maybe we can just add the increased logging from that branch here so if it fails in the merge queue again we at least lern what that consensus item spam is about?

@m1sterc001guy
Copy link
Contributor

Needs rebase but otherwise looks like it works

@tvolk131 tvolk131 force-pushed the update_reqwest branch 3 times, most recently from be6b014 to 9ff5456 Compare April 26, 2024 13:34
@tvolk131
Copy link
Contributor Author

Needs rebase but otherwise looks like it works

Rebased and CI is passing!

elsirion
elsirion previously approved these changes Apr 26, 2024
@elsirion elsirion added this pull request to the merge queue Apr 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2024
m1sterc001guy
m1sterc001guy previously approved these changes May 1, 2024
@tvolk131 tvolk131 force-pushed the update_reqwest branch 3 times, most recently from c9c6101 to e9eca4e Compare May 7, 2024 14:14
@tvolk131 tvolk131 changed the title chore(deps): bump reqwest to 0.12.3 chore(deps): bump reqwest to 0.12.4 May 15, 2024
@tvolk131 tvolk131 force-pushed the update_reqwest branch 2 times, most recently from 59ad00b to 5bd7fb4 Compare May 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants