chore: remove unused dependency features from fedimint-core #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolk131
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
8a89914
to
1c02421
Compare
dpc
previously approved these changes
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
Merge conflict, oof. |
tvolk131
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
1c02421
to
4018821
Compare
|
Oooh, so close! Rebased |
dpc
previously approved these changes
Apr 19, 2024
|
wasm broken |
auto-merge was automatically disabled
April 22, 2024 15:25
Head branch was pushed to by a user without write access
tvolk131
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
4018821
to
1e6d6e7
Compare
dpc
previously approved these changes
Apr 22, 2024
|
@tvolk131 Ping me directly on Discord if you ever need it quickly approved, so we can get it through somehow. :D |
Same. (currently WASM is still broken though) |
auto-merge was automatically disabled
April 26, 2024 15:31
Head branch was pushed to by a user without write access
tvolk131
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
cfaa93c
to
ddc9936
Compare
dpc
previously approved these changes
Apr 26, 2024
|
Cross-compiling is failing. |
|
|
tvolk131
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
ddc9936
to
80e7457
Compare
dpc
previously approved these changes
May 7, 2024
tvolk131
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
80e7457
to
8f1dbfd
Compare
dpc
previously approved these changes
May 21, 2024
|
I pushed a suspected fix for the CI failure, feel free to squash/delete if it works/doesn't. |
This was probably pulled in by another dependency previously.
elsirion
force-pushed
the
fedimint-core_cleanup_cargo_toml
branch
from
ea45f0a
to
c45b799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.