en/de-codeable for lightning_invoice::Invoice

[NicolaLS]

1. helps to put invoices into db
2. will be needed to fix this when this PR is available

[elsirion]

Concept ACK, just two nits. If you find out what is doing the reformatting and if you can either turn it off or enforce it via CI that would be good. Worst case we merge with the reformatting, it's just annoying long term because it makes git blame less useful.

[elsirion]

What software is doing the reformatting here? I'd rather avoid that since it's not checked by CI and will thus diverge again (leading to autoreformatting once you touch it again).

[NicolaLS]

I think IntelliJ idea Settings>tools>actions on safe, I turned that on because I thought it would sort the dependencies but it dosn't do that and I forgot to turn it off

[elsirion]

Ah, there is another setting under Settings>Languages&Frameworks>Rust>Rustfmt "Run rustfmt on Save", that's what I have turned on and what CI verifies. That's better imo because it's independent of any particular IDE.

[elsirion]

You can directly decode strings, no need to go via Vec<u8>

[justinmoon]

So something like this I think ...

String::consensus_decode(d)?
    .parse::<lightning_invoice::Invoice>()
    .map_err(DecodeError::from_err)

[justinmoon]

Also, let's add a unittest. I think the following would work:

    #[test_log::test]
    fn test_invoice() {
        let invoice_str = "lnbc100p1psj9jhxdqud3jxktt5w46x7unfv9kz6mn0v3jsnp4q0d3p2sfluzdx45tqcs\
			h2pu5qc7lgq0xs578ngs6s0s68ua4h7cvspp5q6rmq35js88zp5dvwrv9m459tnk2zunwj5jalqtyxqulh0l\
			5gflssp5nf55ny5gcrfl30xuhzj3nphgj27rstekmr9fw3ny5989s300gyus9qyysgqcqpcrzjqw2sxwe993\
			h5pcm4dxzpvttgza8zhkqxpgffcrf5v25nwpr3cmfg7z54kuqq8rgqqqqqqqq2qqqqq9qq9qrzjqd0ylaqcl\
			j9424x9m8h2vcukcgnm6s56xfgu3j78zyqzhgs4hlpzvznlugqq9vsqqqqqqqlgqqqqqeqq9qrzjqwldmj9d\
			ha74df76zhx6l9we0vjdquygcdt3kssupehe64g6yyp5yz5rhuqqwccqqyqqqqlgqqqqjcqq9qrzjqf9e58a\
			guqr0rcun0ajlvmzq3ek63cw2w282gv3z5uupmuwvgjtq2z55qsqqg6qqqyqqqrtnqqqzq3cqygrzjqvphms\
			ywntrrhqjcraumvc4y6r8v4z5v593trte429v4hredj7ms5z52usqq9ngqqqqqqqlgqqqqqqgq9qrzjq2v0v\
			p62g49p7569ev48cmulecsxe59lvaw3wlxm7r982zxa9zzj7z5l0cqqxusqqyqqqqlgqqqqqzsqygarl9fh3\
			8s0gyuxjjgux34w75dnc6xp2l35j7es3jd4ugt3lu0xzre26yg5m7ke54n2d5sym4xcmxtl8238xxvw5h5h5\
			j5r6drg6k6zcqj0fcwg";
        let invoice = invoice_str.parse::<lightning_invoice::Invoice>().unwrap();
        test_roundtrip(invoice);
    }

Took that invoice from your serde PR.

Otherwise, looks great. Thanks for adding this!

[elsirion]

Thx!