fix: flaky peg_outs_are_only_allowed_once_per_epoch
#1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
commented
Feb 7, 2023
| user.client.reissue_pending_notes(rng()).await.unwrap(); | ||
| fed.run_consensus_epochs(2).await; // reissue the notes from the tx that failed | ||
| fed.await_consensus_epochs(2).await.unwrap(); // reissue the notes from the tx that failed | ||
| user.client.fetch_all_notes().await.unwrap(); |
There was a problem hiding this comment.
I don't understand how it worked before without this. After we call reissue_pending_notes, we need to fetch the new issuance, no?
There was a problem hiding this comment.
The fetch_all_notes is in the assert removed below.
dpc
commented
Feb 7, 2023
| @@ -633,14 +636,19 @@ impl<T: AsRef<ClientConfig> + Clone> Client<T> { | |||
|
|
|||
| /// Should be called after any transaction that might have failed in order to get any note | |||
| /// inputs back. | |||
| #[instrument(skip_all, level = "debug")] | |||
dpc
commented
Feb 7, 2023
| @@ -49,6 +49,11 @@ impl<T> TieredMulti<T> { | |||
| self.0.keys() | |||
| } | |||
|
|
|||
| /// Returns the summary of number of items in each tier | |||
| pub fn summary(&self) -> Tiered<usize> { | |||
There was a problem hiding this comment.
I need to turn it into a separate struct that displays counts per tier and total together.
|
Merging, but please @jkitman help me! I pushed us into this deep water of parallel test execution, and turns out I don't always have enough context to fix issues that arise with it. :D |
jkitman
reviewed
Feb 8, 2023
| dbtx.remove_entry(&key).await.expect("DB Error"); | ||
| } | ||
| dbtx.commit_tx().await.expect("DB Error"); | ||
|
|
||
| self.reissue(all_notes, rng).await | ||
| debug!(target: LOG_WALLET, notes_to_reissue = ?notes_to_reissue.summary(), total = %notes_to_reissue.total_amount()); | ||
| trace!(target: LOG_WALLET, ?notes_to_reissue, "foo"); |
There was a problem hiding this comment.
Nope. I think these are useful, and helped me to debug this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually didn't know why it's failing and had to do some debugging
and decided to leave these in.