Feature/search performance #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of input field. Whenever value changes, a prop called setQueryLater is invoked but only after 500ms
…assed in a curried function to the search component has a prop
|
Hey Anthony, I wanted to let you know that I don’t think this codebase is being actively maintained (I could be wrong). I did look at your implementation and your code looks good. Once we implement search for the new version (the version you’ve also been contributing to), I’ll be sure to consult your implementation and or accept a PR there. 👍 Thank you for all your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#287
#287 (comment)