Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/test printer taskid #1257

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Hotfix/test printer taskid #1257

merged 3 commits into from
Dec 5, 2022

Conversation

davidzwa
Copy link
Collaborator

@davidzwa davidzwa commented Dec 5, 2022

Description

Fix #1256
Fix #1151

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1257 (61ba73a) into develop (7a753ea) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 61ba73a differs from pull request most recent head 44d195a. Consider uploading reports for the commit 44d195a to get more accurate results

@@             Coverage Diff             @@
##           develop    #1257      +/-   ##
===========================================
- Coverage    80.35%   80.34%   -0.01%     
===========================================
  Files          131      131              
  Lines         4255     4254       -1     
  Branches       599      599              
===========================================
- Hits          3419     3418       -1     
  Misses         752      752              
  Partials        84       84              
Flag Coverage Δ
server-nodejs 80.34% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...octoprint/constants/octoprint-service.constants.js 100.00% <100.00%> (ø)
server/services/task-manager.service.js 80.15% <100.00%> (-0.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidzwa davidzwa merged commit 0163a30 into develop Dec 5, 2022
@davidzwa davidzwa deleted the hotfix/test-printer-taskid branch December 5, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant