This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I have a TUI project I'm working on where I've supplied a method to filter out data from the Table widget, using a regex match. Whenever I do this I want to preserve the previous table state, so that the table can still scroll up or down relative to its previous position. For example, if just 1 entry were removed it would be preferable to preserve the offset instead of reset it to 0 and scroll down to the currently selected element. The issue this led to was an out-of-bounds index whenever the offset was greater than the length of the new data. The fix takes only 1 line: clamp the offset to the last index in the new list.