V3 #202
V3 #202
Conversation
cf. 3edca46 NB: this constitutes a breaking change
no longer necessary without virtual bundles (cf. previous commit; separation was originally introduced in d6c7653) this also removes duplicated defaults
NB: this constitutes a breaking change
`sourcemaps` has been the preferred option for ages now; cf. 41bacc6 NB: this constitutes a breaking change
long superseded by Dependabot (cf. 51723c1)
NB: this constitutes a breaking change
Co-authored-by: FND <fnd@localhost.localdomain>
|
FYI: In an effort to refamiliarize myself with this, I've reviewed every commit here and made some minor changes (mostly tweaking and amending commit messages). We'll now need to update our test suite to account for latest transpilation changes, but there are also dependencies to be updated (it might make sense to do the latter first). |
| @@ -14,6 +14,7 @@ module.exports = function generateBundle(entryPoint, config, cache) { | |||
| return bundle.generate(writeConfig); | |||
| }). | |||
| then(({ output }) => { | |||
| output = output.filter(item => item.type !== "asset"); // XXX: simplistic? | |||
There was a problem hiding this comment.
I'm not entirely sure this is correct; it's really hard to keep up with Rollup's API. I mostly guessed based on empiricism and Rollup's change log.
| @@ -6,6 +6,9 @@ module.exports = function generateBundle(entryPoint, config, cache) { | |||
| let { readConfig, writeConfig } = config; | |||
| let options = Object.assign({}, readConfig, { | |||
| input: entryPoint, | |||
| output: { | |||
| generatedCode: "es2015" | |||
There was a problem hiding this comment.
Yes, it is weird. For me, the option sounds like something we SHOULD set. But it's weird that we can't find any consequences in the code... I would still vote for keeping the option in here, even though it feels weird.
?
This PR introduces a few breaking changes. We collect them to have a nice, clean v3 - dropping some things that drag us down along the way.
We drop Virtual entirely. It was not used, and adds significant complexity
We drop support for custom extensions
We make ESM the new default format (previously it was IIFE). It is a breaking change, but a very necessary one.
Remove an old unused test util and a really old deprecation warning
We drop support for Node 14
Use ES2015 Syntax in generated code