Added Async/Await and Promise support and fixed a bug #3
Conversation
There was a problem hiding this comment.
This is an outstanding piece of work. Thank you!
At first I was under the influence of the Not-Invented-Here syndrom when browsing the code and looking at the structural changes, but it really is much better than my initial attempt at this and a delightful display of how readable handling async code can be when using ES2015 syntax. I am not in love with the integration style testing using fixtures, but it works and is easy to reason about, so ✔️in my book. Pragmatism gets better results than dogmatism any day :)
I could just merge this as it is, as it is seemingly non-breaking and strictly adding features, but it doesn't address the most important aspect for me: handling the good old callback-style API. It's the most basic case, so for me, it IS a big thing to get right, but more importantly, I think you are 99% there. I added a suggestion for how you could handle it: basically wrapping any fn with length==1 in a promise before handing it over to the flow you already have going. That should work with it, before, afterEach and all the rest, although the actuals details may be a bit more involved than the simple addition mentioned above.
What do you think? Would you like to have a try at handling it in this one, which I think would make sense, or leave it for later? It would make sense to have it in this one, wrt the scope.
P.S. Could you rebase your changes into more meaningful commits - possibly just one?
|
@fatso83 , |
|
The last changes seem great! Look forward to testing them out. P.S. In case it's foreign, here's an intro to interactive rebasing. |
Based on what I made on https://runkit.com/fatso83/sinon-test-issue-101 1.0.1 1.0.1 Handle multiple describe blocks 1.0.2 Update README.md 1.0.3 API change: setup() and explicit exports Now with test coverage Verify input 2.0.0 Gitignore Fix typo for v2 2.0.1 Only include one file initlai attempt fix none async path fix none async path fix none async path added async support update demo file restructure the code bit small change small change added tests Added callback support Added callback support update tests
|
I really suck at GIT stuff. sorry about this. ill open a new PR. |
Hi @fatso83 ,
This is my first attempt to add async support to the mini-mocha.
In this PR,
async/awaitand fixed the bug thatbeforeEachwas not executed for all.donecallback is not supported. (Do you need that functionality?)Hope to get feedback from you.