Update golang.org/x/sys for Go 1.18 on M1 Macs. #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spoke too soon, it was accepted! When a new version is released, I will either create a new PR to remove the indirect dependency if this is also merged, or I will update this PR if it hasn't yet. |
|
I updated |
This picks up a new 2022 version of golang.org/x/sys which is caused by golang/go#49219 and is needed to fix building using Go 1.18 on aarch64-darwin.
|
I just noticed that this was done automatically by dependabot in b3652af. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up a new 2022 version of golang.org/x/sys which is caused by golang/go#49219 and is needed to fix building using Go 1.18 on aarch64-darwin.
By including this here, when a new version with this change is released, consumers will not need to specify their own indirect dependency on a newer version of golang.org/x/sys.
In an ideal world, mattn/go-isatty#75 will be accepted and a new version published, so that this can be picked up through it without an indirect dependency, but I am opening a change here too because this project is more active than that one at the moment.