Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snapshot] fix compiler error on SnapshotHelper.swift #20689

Merged
merged 3 commits into from Nov 12, 2022
Merged

[snapshot] fix compiler error on SnapshotHelper.swift #20689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b6bdf6
SnapshotHelper.swift has Swift Compiler Error #18792
amcalgates Sep 22, 2022
27d439f
Merge branch 'master' into snapshot-fix-swift-compiler-check
amcalgates Oct 6, 2022
6609e7a
Updated snapshot helper version
joshdholtz Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions snapshot/lib/assets/SnapshotHelper.swift
View file
Open in desktop
Expand Up @@ -181,7 +181,7 @@ open class Snapshot: NSObject {

let path = screenshotsDir.appendingPathComponent("\(simulator)-\(name).png")
#if swift(<5.0)
rogerluan marked this conversation as resolved.
Show resolved Hide resolved
UIImagePNGRepresentation(image)?.write(to: path, options: .atomic)
try UIImagePNGRepresentation(image)?.write(to: path, options: .atomic)
#else
try image.pngData()?.write(to: path, options: .atomic)
#endif
Expand Down Expand Up @@ -306,4 +306,4 @@ private extension CGFloat {

// Please don't remove the lines below
// They are used to detect outdated configuration files
// SnapshotHelperVersion [1.28]
// SnapshotHelperVersion [1.29]