Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action] add xcodes action, deprecating xcversion and xcode-install #20672

Merged
merged 29 commits into from Nov 12, 2022
Merged

[action] add xcodes action, deprecating xcversion and xcode-install #20672

merged 29 commits into from Nov 12, 2022

Commits on Nov 2, 2022

  1. Move helpers to a separate and centralized file.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7c1de15 View commit details
    Browse the repository at this point in the history

  2. Deprecate 'xcode-install' gem (the project has been sunset), adding '… 

    …xcodes' action to replace the 'xcode_install' one.
    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    676e3ee View commit details
    Browse the repository at this point in the history

  3. Add 'select_only' option to 'xcodes', deprecating 'xcversion' action.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    8c5c733 View commit details
    Browse the repository at this point in the history

  4. Update documentation to state it also supports .xcode-version file.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    eb583d5 View commit details
    Browse the repository at this point in the history

  5. Add TODO for a future improvement.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    54786b0 View commit details
    Browse the repository at this point in the history

  6. Lint.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    b8d6090 View commit details
    Browse the repository at this point in the history

  7. Fix link.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    766c53b View commit details
    Browse the repository at this point in the history

  8. Remove TODO comment.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    6d6ff1f View commit details
    Browse the repository at this point in the history

  9. Lint.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c9670be View commit details
    Browse the repository at this point in the history

  10. Fix typo in error being raised.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    97dff12 View commit details
    Browse the repository at this point in the history

  11. Add ability to select Xcode just for current build, without sudo perm… 

    …issions.

- Depends on XcodesOrg/xcodes#220
    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c1c32ee View commit details
    Browse the repository at this point in the history

  12. Update documentation to point to 'xcodes' instead.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c2dafb7 View commit details
    Browse the repository at this point in the history

  13. Update xcodes link.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7e84283 View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review. 

    Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com>
    @rogerluan @revolter
    rogerluan and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    5675137 View commit details
    Browse the repository at this point in the history

  15. Change "#" by "." in spec descriptions, to indicate class methods.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4b5d083 View commit details
    Browse the repository at this point in the history

  16. Apply suggestion from code review.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    083af9f View commit details
    Browse the repository at this point in the history

  17. Improve documentation around requirements to run xcodes.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    5f9b24e View commit details
    Browse the repository at this point in the history

  18. Remove necessity to authenticate with Apple servers since xcodes v1.0.0.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    23b33e8 View commit details
    Browse the repository at this point in the history

  19. Use new --update and --selected arguments, which require xcodes v1.1.0.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    d66a490 View commit details
    Browse the repository at this point in the history

  20. Fix comparing Gem::Version with String error

    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9fc0824 View commit details
    Browse the repository at this point in the history

  21. Remove unused local variable

    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    ccf5ec6 View commit details
    Browse the repository at this point in the history

  22. Split long lines

    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    594d707 View commit details
    Browse the repository at this point in the history

  23. Fix lint issues

    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    30cd166 View commit details
    Browse the repository at this point in the history

  24. Address style comments.

    @rogerluan @revolter
    rogerluan authored and revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    136b664 View commit details
    Browse the repository at this point in the history

  25. Remove superfluous trailing slash 

    This makes it consistent with the rest of the codebase.
    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    7d0caea View commit details
    Browse the repository at this point in the history

  26. Fix unsafe paths concatenation

    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    317296b View commit details
    Browse the repository at this point in the history

  27. Fix some WWDR certificates test failure 

    This was caused by the fact that that test calls a method that uses `$?`
(https://stackoverflow.com/a/6834572/865175), which, somehow, (I think)
was executed right after a call to XcodesHelper's
`find_xcodes_binary_path` method. This latter one returned a non-zero
code, because `xcodes` can't be installed on Ubuntu, which got picked up
by the certificates return code check, so it treated its actual command
as failed.
    @revolter
    revolter committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    11bd750 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Replace Actions.sh call with a native one 

    (reverted from commit 11bd750)
    @revolter
    revolter committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1a27157 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Fix error-prone shell command status check 

    In the case of the tests, `$?` was not mocked, so it looks like it was
indeed just a coincidence that it worked. Meaning, some other shell
command that somehow was actually executed (so it wasn't stubbed)
succeeded, which caused the `$?.success?` to succeed too.
    @revolter
    revolter committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    58a0ed9 View commit details
    Browse the repository at this point in the history