Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action][hockey] remove all instances of is_string in options and use type #18909

Merged
merged 1 commit into from Jun 22, 2021
Merged

[action][hockey] remove all instances of is_string in options and use type #18909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 5 additions & 12 deletions fastlane/lib/fastlane/actions/hockey.rb
View file
Open in desktop
Expand Up @@ -226,19 +226,13 @@ def self.available_options
description: "Path to your symbols file. For iOS and Mac provide path to app.dSYM.zip. For Android provide path to mappings.txt file",
default_value: Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH],
default_value_dynamic: true,
optional: true,
verify_block: proc do |value|
# validation is done in the action
end),
optional: true),
FastlaneCore::ConfigItem.new(key: :create_update,
env_name: "FL_HOCKEY_CREATE_UPDATE",
description: "Set true if you want to create then update your app as opposed to just upload it."\
" You will need the 'public_identifier', 'bundle_version' and 'bundle_short_version'",
is_string: false,
default_value: false,
verify_block: proc do |value|
# validation is done in the action
end),
type: Boolean,
default_value: false),
FastlaneCore::ConfigItem.new(key: :notes,
env_name: "FL_HOCKEY_NOTES",
description: "Beta Notes",
Expand Down Expand Up @@ -307,7 +301,7 @@ def self.available_options
FastlaneCore::ConfigItem.new(key: :upload_dsym_only,
env_name: "FL_HOCKEY_UPLOAD_DSYM_ONLY",
description: "Flag to upload only the dSYM file to hockey app",
is_string: false,
type: Boolean,
default_value: false),
FastlaneCore::ConfigItem.new(key: :owner_id,
env_name: "FL_HOCKEY_OWNER_ID",
Expand All @@ -328,12 +322,11 @@ def self.available_options
FastlaneCore::ConfigItem.new(key: :bypass_cdn,
env_name: "FL_HOCKEY_BYPASS_CDN",
description: "Flag to bypass Hockey CDN when it uploads successfully but reports error",
is_string: false,
type: Boolean,
default_value: false),
FastlaneCore::ConfigItem.new(key: :dsa_signature,
env_name: "FL_HOCKEY_DSA_SIGNATURE",
description: "DSA signature for sparkle updates for macOS",
is_string: true,
default_value: "",
optional: true)
]
Expand Down