Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][gradle] remove all instances of is_string in options and use type #18905

Merged
merged 1 commit into from Jun 22, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 11 additions & 19 deletions fastlane/lib/fastlane/actions/gradle.rb
Expand Up @@ -146,64 +146,56 @@ def self.available_options
env_name: 'FL_GRADLE_TASK',
description: 'The gradle task you want to execute, e.g. `assemble`, `bundle` or `test`. For tasks such as `assembleMyFlavorRelease` you should use gradle(task: \'assemble\', flavor: \'Myflavor\', build_type: \'Release\')',
conflicting_options: [:tasks],
optional: true,
is_string: true),
optional: true),
FastlaneCore::ConfigItem.new(key: :flavor,
env_name: 'FL_GRADLE_FLAVOR',
description: 'The flavor that you want the task for, e.g. `MyFlavor`. If you are running the `assemble` task in a multi-flavor project, and you rely on Actions.lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH] then you must specify a flavor here or else this value will be undefined',
optional: true,
is_string: true),
optional: true),
FastlaneCore::ConfigItem.new(key: :build_type,
env_name: 'FL_GRADLE_BUILD_TYPE',
description: 'The build type that you want the task for, e.g. `Release`. Useful for some tasks such as `assemble`',
optional: true,
is_string: true),
optional: true),
FastlaneCore::ConfigItem.new(key: :tasks,
type: Array,
env_name: 'FL_GRADLE_TASKS',
description: 'The multiple gradle tasks that you want to execute, e.g. `[assembleDebug, bundleDebug]`',
conflicting_options: [:task],
optional: true,
is_string: false),
optional: true),
FastlaneCore::ConfigItem.new(key: :flags,
env_name: 'FL_GRADLE_FLAGS',
description: 'All parameter flags you want to pass to the gradle command, e.g. `--exitcode --xml file.xml`',
optional: true,
is_string: true),
optional: true),
FastlaneCore::ConfigItem.new(key: :project_dir,
env_name: 'FL_GRADLE_PROJECT_DIR',
description: 'The root directory of the gradle project',
default_value: '.',
is_string: true),
default_value: '.'),
FastlaneCore::ConfigItem.new(key: :gradle_path,
env_name: 'FL_GRADLE_PATH',
description: 'The path to your `gradlew`. If you specify a relative path, it is assumed to be relative to the `project_dir`',
optional: true,
is_string: true),
optional: true),
FastlaneCore::ConfigItem.new(key: :properties,
env_name: 'FL_GRADLE_PROPERTIES',
description: 'Gradle properties to be exposed to the gradle script',
optional: true,
is_string: false),
type: Hash),
FastlaneCore::ConfigItem.new(key: :system_properties,
env_name: 'FL_GRADLE_SYSTEM_PROPERTIES',
description: 'Gradle system properties to be exposed to the gradle script',
optional: true,
is_string: false),
type: Hash),
FastlaneCore::ConfigItem.new(key: :serial,
env_name: 'FL_ANDROID_SERIAL',
description: 'Android serial, which device should be used for this command',
is_string: true,
default_value: ''),
FastlaneCore::ConfigItem.new(key: :print_command,
env_name: 'FL_GRADLE_PRINT_COMMAND',
description: 'Control whether the generated Gradle command is printed as output before running it (true/false)',
is_string: false,
type: Boolean,
default_value: true),
FastlaneCore::ConfigItem.new(key: :print_command_output,
env_name: 'FL_GRADLE_PRINT_COMMAND_OUTPUT',
description: 'Control whether the output produced by given Gradle command is printed while running (true/false)',
is_string: false,
type: Boolean,
default_value: true)
]
end
Expand Down