Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action][download_dsyms] remove all instances of is_string in options and use type #18870

Merged
merged 1 commit into from Jun 15, 2021
Merged

[action][download_dsyms] remove all instances of is_string in options and use type #18870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions fastlane/lib/fastlane/actions/download_dsyms.rb
View file
Open in desktop
Expand Up @@ -253,7 +253,7 @@ def self.available_options
env_name: "DOWNLOAD_DSYMS_TEAM_ID",
description: "The ID of your App Store Connect team if you're in multiple teams",
optional: true,
is_string: false, # as we also allow integers, which we convert to strings anyway
skip_type_validation: true, # as we also allow integers, which we convert to strings anyway
code_gen_sensitive: true,
default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_team_id),
default_value_dynamic: true,
Expand Down Expand Up @@ -286,7 +286,7 @@ def self.available_options
env_name: "DOWNLOAD_DSYMS_BUILD_NUMBER",
description: "The app build_number for dSYMs you wish to download",
optional: true,
is_string: false),
skip_type_validation: true), # as we also allow integers, which we convert to strings anyway
FastlaneCore::ConfigItem.new(key: :min_version,
short_option: "-m",
env_name: "DOWNLOAD_DSYMS_MIN_VERSION",
Expand All @@ -296,8 +296,7 @@ def self.available_options
short_option: "-d",
env_name: "DOWNLOAD_DSYMS_AFTER_UPLOADED_DATE",
description: "The uploaded date after which you wish to download dSYMs",
optional: true,
is_string: true),
optional: true),
FastlaneCore::ConfigItem.new(key: :output_directory,
short_option: "-s",
env_name: "DOWNLOAD_DSYMS_OUTPUT_DIRECTORY",
Expand Down