Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spaceship] parse response body as json if not already #18766

Merged
merged 6 commits into from Jun 23, 2021
Merged

[spaceship] parse response body as json if not already #18766

merged 6 commits into from Jun 23, 2021

Commits on May 28, 2021

  1. parse response body as json if not already 

    parse response body as json if not already
    Muhammet Ilendemli committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8d1120f View commit details
    Browse the repository at this point in the history

  2. parse if response.body is type of String

    Muhammet Ilendemli committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8e81adf View commit details
    Browse the repository at this point in the history

  3. fixes broken test

    Muhammet Ilendemli committed May 28, 2021
    Configuration menu
    Copy the full SHA
    a8f377a View commit details
    Browse the repository at this point in the history

  4. check if response is empty and use empty json object if so, else try … 

    …parse the body
    Muhammet Ilendemli committed May 28, 2021
    Configuration menu
    Copy the full SHA
    4725f99 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Clean up logic and removed unneeded if statements and added tests

    Josh Holtz committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    540f384 View commit details
    Browse the repository at this point in the history

  2. Add test for string json

    Josh Holtz committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    cd75ed1 View commit details
    Browse the repository at this point in the history