Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby 3.0] replace slack-notifier gem with internal library #18537

Merged
merged 11 commits into from
Apr 30, 2021
Merged

[Ruby 3.0] replace slack-notifier gem with internal library #18537

merged 11 commits into from
Apr 30, 2021

Commits on Apr 30, 2021

  1. Implement FastlaneCore::Slack::LinkConverter

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    eb8ab68 View commit details
    Browse the repository at this point in the history

  2. Implment Slack#post_to_legacy_incoming_webhook

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d502696 View commit details
    Browse the repository at this point in the history

  3. Rename FastlaneCore::Slack to Fastlane::Notification::Slack

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    9a0d4e5 View commit details
    Browse the repository at this point in the history

  4. Fix comment

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    765597f View commit details
    Browse the repository at this point in the history

  5. Fix Fastlane::Notification::Slack

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    5d72af0 View commit details
    Browse the repository at this point in the history

  6. Repalce slack-notifier with Fastlane::Notification::Slack

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    25fdbc3 View commit details
    Browse the repository at this point in the history

  7. Get rid of slack-notifier

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    a484d5a View commit details
    Browse the repository at this point in the history

  8. Fix HTML_PATTERN

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    191a9ae View commit details
    Browse the repository at this point in the history

  9. Add specs

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    c7dfc67 View commit details
    Browse the repository at this point in the history

  10. Fix format by rubocop

    @ainame
    ainame committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    0794a34 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @ainame @rogerluan
    ainame and rogerluan committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    1541c8f View commit details
    Browse the repository at this point in the history