Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] fix compiler error on SnapshotHelper.swift #20689

Merged

Conversation

amcalgates
Copy link
Contributor

@amcalgates amcalgates commented Sep 22, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Additional fix for #18792
Resolves #18792

Description

I still see #18792 after updating. Running fastlane snapshot init seems to copy the file from snapshot/lib/assets/SnapshotHelper.swift which is different than the file that was modified in #18930

Testing Steps

Running fastlane snapshot init should cause snapshot/lib/assets/SnapshotHelper.swift to be copied to your project folder, and this version of the file is missing the try statement and does not compile.

@google-cla
Copy link

google-cla bot commented Sep 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rogerluan rogerluan changed the title SnapshotHelper.swift has Swift Compiler Error #18792 [snapshot][Fastlane.swift] fix compiler error on SnapshotHelper.swift Sep 25, 2022
@minuscorp
Copy link
Collaborator

But at some point this was broken with Swift 5.0, another if clause should be added to know when it was added the throws statement. Probably in the latest release with Swift 5.7

Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the comment above🙏

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @amcalgates ! Your solution makes total sense — I think the reproducibility instructions of #18792 were off 😬

Just left a comment!

snapshot/lib/assets/SnapshotHelper.swift Show resolved Hide resolved
Copy link
Collaborator

@minuscorp minuscorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the resolution of the pending discussions, this PR now LGTM! 🙌 Thanks again for this @amcalgates ! 🚀

@rogerluan rogerluan changed the title [snapshot][Fastlane.swift] fix compiler error on SnapshotHelper.swift [snapshot] fix compiler error on SnapshotHelper.swift Oct 6, 2022
@rogerluan
Copy link
Member

@amcalgates could you rebase/merge master into your branch, please? Something went wrong with CI and it's not letting me re-trigger it

@amcalgates
Copy link
Contributor Author

I've rebased + merged master. I'm not entirely sure what I'm supposed to be doing with CircleCI... presumably nothing? But I've played around with it for a bit and gotten nowhere. Let me know if there's anything I need to be doing.

@rogerluan
Copy link
Member

Yeah you shouldn't need to do anything, no clue why your PR in particular isn't working though 🤔

@rogerluan
Copy link
Member

It seems to be an issue on CircleCI's end, but no clue how to overcome it https://discuss.circleci.com/t/release-build-fails-because-deleted-the-circleci-oauth-app/45101/5

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this PR 😊

@joshdholtz joshdholtz merged commit e59bb1c into fastlane:master Nov 12, 2022
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[snapshot] SnapshotHelper.swift has Swift Compiler Error
5 participants